<html>
<head><meta charset="utf-8"><title>review #89 · wg-async-foundations · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/index.html">wg-async-foundations</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/review.20.2389.html">review #89</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="232274667"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/review%20%2389/near/232274667" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Doc Jones <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/review.20.2389.html#232274667">(Mar 29 2021 at 14:14)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span> Do you have time to review changes in <a href="https://github.com/rust-lang/rust/issues/89">#89</a>?</p>



<a name="232274686"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/review%20%2389/near/232274686" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/review.20.2389.html#232274686">(Mar 29 2021 at 14:15)</a>:</h4>
<p>yep, doing that now</p>



<a name="232274697"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/review%20%2389/near/232274697" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/review.20.2389.html#232274697">(Mar 29 2021 at 14:15)</a>:</h4>
<p><a href="https://github.com/rust-lang/wg-async-foundations/issues/89">wg-async-foundations#89</a></p>



<a name="232274734"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/review%20%2389/near/232274734" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/review.20.2389.html#232274734">(Mar 29 2021 at 14:15)</a>:</h4>
<p>or rather, I'm doing a bit of a sweep</p>



<a name="232274745"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/review%20%2389/near/232274745" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/review.20.2389.html#232274745">(Mar 29 2021 at 14:15)</a>:</h4>
<p>I'll take a look at that next :)</p>



<a name="232275314"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/review%20%2389/near/232275314" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/review.20.2389.html#232275314">(Mar 29 2021 at 14:18)</a>:</h4>
<p>I saw <span class="user-mention" data-user-id="394977">@Doc Jones</span> and interesting comment from galich</p>



<a name="232275773"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/review%20%2389/near/232275773" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Doc Jones <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/review.20.2389.html#232275773">(Mar 29 2021 at 14:21)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116009">nikomatsakis</span> <a href="#narrow/stream/187312-wg-async-foundations/topic/review.20.2389/near/232275314">said</a>:</p>
<blockquote>
<p>I saw <span class="user-mention silent" data-user-id="394977">Doc Jones</span> and interesting comment from galich</p>
</blockquote>
<p>Yes, I see that.  I guess I missed it.  Should I include his code with the narrative?</p>



<a name="232275955"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/review%20%2389/near/232275955" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Doc Jones <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/review.20.2389.html#232275955">(Mar 29 2021 at 14:22)</a>:</h4>
<p>It makes sense to add detail of the confusion he describes.  I'll add that sometime today.</p>



<a name="232277920"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/review%20%2389/near/232277920" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/review.20.2389.html#232277920">(Mar 29 2021 at 14:34)</a>:</h4>
<p><span class="user-mention" data-user-id="394977">@Doc Jones</span> I included some suggestions</p>



<a name="232277926"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/review%20%2389/near/232277926" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/review.20.2389.html#232277926">(Mar 29 2021 at 14:34)</a>:</h4>
<p>take a look</p>



<a name="232277944"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/review%20%2389/near/232277944" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/review.20.2389.html#232277944">(Mar 29 2021 at 14:34)</a>:</h4>
<p><a href="https://github.com/rust-lang/wg-async-foundations/pull/89#pullrequestreview-623285844">review</a></p>



<a name="232281346"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/review%20%2389/near/232281346" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Doc Jones <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/review.20.2389.html#232281346">(Mar 29 2021 at 14:55)</a>:</h4>
<p>I have committed the changes and updated the FAQs as you recommended.</p>



<a name="232281865"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/review%20%2389/near/232281865" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/review.20.2389.html#232281865">(Mar 29 2021 at 14:58)</a>:</h4>
<p><span class="user-mention" data-user-id="394977">@Doc Jones</span> great, just took a look, the only thing left was to remove the bullets</p>



<a name="232281873"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/review%20%2389/near/232281873" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/review.20.2389.html#232281873">(Mar 29 2021 at 14:58)</a>:</h4>
<p>I could maybe jsut do that real quick if you don't have time</p>



<a name="232282316"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/review%20%2389/near/232282316" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Doc Jones <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/review.20.2389.html#232282316">(Mar 29 2021 at 15:00)</a>:</h4>
<p>So just delete all of the bullets?  Is that correct?</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>